Draczech commented on a change in pull request #12560:
URL: https://github.com/apache/flink/pull/12560#discussion_r438086367
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -217,11 +219,19 @@ private void runArchiveExpirationTest(boolean
cleanupExpiredJobs) throws Excepti
.map(JobID::toString)
.filter(jobId -> jobId.equals(jobIdToDelete))
.count());
+ assertHSFilesExistence(jobIdToDelete,
!cleanupExpiredJobs);
Review comment:
Well, the purpose of the fix was deleting files. As there haven't been
any test for that so far I added them to show that now all files are deleted
properly with HS cleaning feature enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
