[GitHub] [flink] curcur commented on a change in pull request #12525: [FLINK-17769] [runtime] Fix the order of log events on a task failure

[GitBox]

curcur commented on a change in pull request #12525:
URL: https://github.com/apache/flink/pull/12525#discussion_r439181590



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -613,25 +614,31 @@ protected void cleanUpInvoke() throws Exception {
                // stop all timers and threads
                tryShutdownTimerService();

Review comment:
       I have no idea, the current change does not change the behavior of 
`cleanUpInvoke`. 
   
   I am a bit hesitant to make changes to change the behavior.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org