curcur commented on a change in pull request #12525:
URL: https://github.com/apache/flink/pull/12525#discussion_r439197606
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -702,11 +714,14 @@ private void disposeAllOperators(boolean logOnlyErrors)
throws Exception {
operator.dispose();
}
catch (Exception e) {
Review comment:
Hmm... Yes a little bit, is it safe to make the change since all the
functions are throwing exceptions in this class.
I kind of feeling non-consistent way of using Throwable and Exception in
this class, but I guess it is out-of-scope of this fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
