curcur commented on a change in pull request #12525:
URL: https://github.com/apache/flink/pull/12525#discussion_r439194857



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -613,25 +614,31 @@ protected void cleanUpInvoke() throws Exception {
                // stop all timers and threads
                tryShutdownTimerService();
 
+               Throwable suppressedThrowable = null;

Review comment:
       > I guess we can't use Guava `Closer` because we want to handle any type 
of exception, right?
   > And not CloseableRegistry because it closes silently.
   
   Hmm, need more context to understand this part.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to