rkhachatryan commented on pull request #12670: URL: https://github.com/apache/flink/pull/12670#issuecomment-644839624
Thanks for the feedback @ifndef-SleePy and @tillrohrmann. I agree that changes exceed the scope of the original problem so I dropped most of them leaving a single commit. I'll publish less-urgent followup PR later and address your comments there. > Moreover, I think that we are missing a test case for the original problem. I couldn't find a good way to test the fix (the root problem involves two threads without accessible synchronization points). > Maybe the following approach would be a bit less invasive: https://github.com/tillrohrmann/flink/commits/FLINK-18290-alt. I think it won't help because it will only fail the timer thread, potentially leaving job unaffected and JM/JVM running. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
