[GitHub] [flink] rkhachatryan commented on a change in pull request #12670: [FLINK-18290][checkpointing] Fail job on checkpoint future failure instead of System.exit

[GitBox]

rkhachatryan commented on a change in pull request #12670:
URL: https://github.com/apache/flink/pull/12670#discussion_r440964641



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java
##########
@@ -84,7 +84,7 @@ public void handleTaskLevelCheckpointException(
        private void handleException(CheckpointException exception, long 
checkpointId, BiConsumer<FailJobCallback, Exception> onFailure) {
                if (isFailure(exception) &&
                                countedCheckpointIds.add(checkpointId) &&
-                               continuousFailureCounter.incrementAndGet() > 
tolerableCpFailureNumber) {
+                               continuousFailureCounter.incrementAndGet() == 
tolerableCpFailureNumber + 1) {

Review comment:
       I've 
[added](https://github.com/apache/flink/pull/12686/commits/d6aee67fbaa9980d336eb8518d002dcda4f10646#diff-0526f121583ad31a2b7c9c9607de9144R34)
 `testOnlySucceededCheckpointIdRemoved` in #12686 to demonstrate this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org