[GitHub] [flink] rkhachatryan commented on a change in pull request #12670: [FLINK-18290][checkpointing] Fail job on checkpoint future failure instead of System.exit

[GitBox]

rkhachatryan commented on a change in pull request #12670:
URL: https://github.com/apache/flink/pull/12670#discussion_r440965447



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java
##########
@@ -83,9 +83,10 @@ public void handleTaskLevelCheckpointException(
 
        private void handleException(CheckpointException exception, long 
checkpointId, BiConsumer<FailJobCallback, Exception> onFailure) {
                if (isFailure(exception) &&
+                               !isAlreadyFailed() && // prevent unnecessary 
storing checkpointId
                                countedCheckpointIds.add(checkpointId) &&
                                continuousFailureCounter.incrementAndGet() == 
tolerableCpFailureNumber + 1) {
-                       clearCount();

Review comment:
       I will address it in #12686.

##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManagerTest.java
##########
@@ -76,7 +76,7 @@ public void testTotalCountValue() {
                        failureManager.handleJobLevelCheckpointException(new 
CheckpointException(reason), -1);
                }
 
-               assertEquals(2, callback.getInvokeCounter());
+               assertEquals(1, callback.getInvokeCounter());

Review comment:
       I will address it in #12686.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org