danmagyar commented on a change in pull request #12636:
URL: https://github.com/apache/flink/pull/12636#discussion_r441381336
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java
##########
@@ -99,6 +99,11 @@
.withDescription("Enable HTTPs access to the
HistoryServer web frontend. This is applicable only when the" +
" global SSL flag security.ssl.enabled is set
to true.");
+ public static final ConfigOption<Integer> HISTORY_SERVER_MAX_SIZE =
+ key("historyserver.max.history.size")
Review comment:
Thanks Till, I agree, the current name does not fit in the already
established hierarchical structure. I'd actually build upon your proposal and
suggest the name `historyserver.archive.retained-jobs`, which seems to be even
more consistent with the existing parameters, given that the current behaviour
works on the same abstraction level as the behaviour controlled by
`historyserver.archive.clean-expired-jobs`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
