danmagyar commented on a change in pull request #12636:
URL: https://github.com/apache/flink/pull/12636#discussion_r443022580
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java
##########
@@ -99,6 +99,13 @@
.withDescription("Enable HTTPs access to the
HistoryServer web frontend. This is applicable only when the" +
" global SSL flag security.ssl.enabled is set
to true.");
+ public static final ConfigOption<Integer> HISTORY_SERVER_RETAINED_JOBS =
+ key("historyserver.archive.retained-jobs")
+ .defaultValue(-1)
+ .withDescription(String.format("The maximum number of
jobs to retain in each archive directory" +
+ " defined by `%s`. If set to `-1`(default) or
negative, there is no limit to the number of archives" +
+ " to keep in the directories and the cache. If
set to `0`, no archives are kept.", HISTORY_SERVER_ARCHIVE_DIRS.key()));
Review comment:
Thanks for clarifying @zentol and @tillrohrmann, your points make
perfect sense. I didn't consider the case of incorrectly generated configs for
which I'm all for failing fast.
I also find it cleaner to reserve the `0` value for a later behaviour
refinement rather than tolerating the users' error and trying to find out what
do they wanted to configure. Besides this makes it easier to test these values.
I've updated the PR accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
