danmagyar commented on a change in pull request #12636:
URL: https://github.com/apache/flink/pull/12636#discussion_r442731695
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java
##########
@@ -99,6 +99,13 @@
.withDescription("Enable HTTPs access to the
HistoryServer web frontend. This is applicable only when the" +
" global SSL flag security.ssl.enabled is set
to true.");
+ public static final ConfigOption<Integer> HISTORY_SERVER_RETAINED_JOBS =
+ key("historyserver.archive.retained-jobs")
+ .defaultValue(-1)
+ .withDescription(String.format("The maximum number of
jobs to retain in each archive directory" +
+ " defined by `%s`. If set to `-1`(default) or
negative, there is no limit to the number of archives" +
+ " to keep in the directories and the cache. If
set to `0`, no archives are kept.", HISTORY_SERVER_ARCHIVE_DIRS.key()));
Review comment:
Yeah, you are right, I indeed missed that. I might come back and
separate the handling of running jobs vs finished jobs under a different PR.
@zentol @tillrohrmann, could you please help me understand how would you
like to see a `0` value handled? I'm a bit confused about what do you mean by
failing and not accepting values.
In my opinion, it'd be the easiest and most userfriendly if we'd just fall
back to the default disabled mode on every non-positive (<=0) values, i.e.
handling `0` and `-1` the same way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
