Jiayi-Liao commented on a change in pull request #12706:
URL: https://github.com/apache/flink/pull/12706#discussion_r442109907
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -169,9 +169,8 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
@Override
Optional<BufferAndAvailability> getNextBuffer() throws IOException {
- checkState(partitionRequestClient != null, "Queried for a
buffer before requesting a queue.");
-
checkError();
+ checkState(partitionRequestClient != null, "Queried for a
buffer before requesting a queue.");
Review comment:
BTW, is the message "before requesting a queue" right? Because we're
actually requesting a partition. I'm not sure whether we use this message,
maybe some historical reasons from non-credit-based network model?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
