Jiayi-Liao opened a new pull request #12706:
URL: https://github.com/apache/flink/pull/12706
## What is the purpose of the change
The error will be set and `partitionRequestClient` will be a null value if a
remote channel fails to request the partition at the beginning. And the task
will fail because `partitionRequestClient` is null when the task thread trying
to fetch data from channels.
But the root cause is the PartitionConnectionException we set when
requesting the partition.
## Brief change log
* Reverse the calls between `checkError` and `checkState`
* (unit testing change) Register channel in `InputGate` when creating a new
channel
## Verifying this change
* Add `testPartitionConnectionException`, the
`TestingExceptionConnectionManager` will set `PartitionConnectionException` as
error when requesting a new partition. And the channel should throw
`PartitionConnectionException` when fetching data.
(You can see the wrong behaviour by removing the changes in
`RemoteInputChannel`)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive):
yes(per-buffer not per-record)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
