Jiayi-Liao commented on a change in pull request #12706:
URL: https://github.com/apache/flink/pull/12706#discussion_r442283026
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -169,9 +169,8 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
@Override
Optional<BufferAndAvailability> getNextBuffer() throws IOException {
- checkState(partitionRequestClient != null, "Queried for a
buffer before requesting a queue.");
-
checkError();
+ checkState(partitionRequestClient != null, "Queried for a
buffer before requesting a queue.");
Review comment:
@pnowojski Yes. I've checked other places including :
* notifyCreditAvailable: called from netty thread after the connection is
built.
* resumeConsumption: called when receiving barriers.
* retriggerPartitionRequest: called after the connection is built.
* sendTaskEvent: the exception will be thrown directly to StreamTask /
Environment
If I understand correctly, none of them will cause this issue. But it's also
reasonable to add this additional check and bind them together because we may
introduce other changes that cause this.
@pnowojski I'll be fine if it's needed. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
