KarmaGYZ commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r442592928
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -91,7 +93,8 @@
private static final int STARTUP_FAILURE_RETURN_CODE = 1;
- public static final int RUNTIME_FAILURE_RETURN_CODE = 2;
+ @VisibleForTesting
Review comment:
I saw this field only used in `TaskManagerRunner.java` and testing code.
So I think it probably not makes sense to set the access modifier to `public`.
However, we could not set it to `private` as it is used by testing code. So, I
change it to `package-private` and annotate it with `VisibleForTesting`. It
just a hotfix though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
