KarmaGYZ commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r443294370
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,6 +257,18 @@
text("\"ip\" - uses host's ip address
as binding address"))
.build());
+ /**
+ * The prefix of the TaskManager's ResourceID. If configured, the
ResourceID will be generated with the prefix and a
+ * 6-character random string. Otherwise, a random string will be used.
Only valid in standalone mode.
+ */
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ public static final ConfigOption<String>
TASK_MANAGER_RESOURCE_ID_PREFIX =
+ key("taskmanager.resource-id.prefix")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The prefix of the TaskManager's
ResourceID. If configured, the ResourceID will be generated with the prefix "
+ + "and a 6-character random string. Otherwise,
a random string will be used. Only valid in standalone mode.");
Review comment:
Ahh, I think I misunderstand what you mean by "step back". You mean we
could set the `ResourceID` to `host-uuid` by default. But for the RM
implementations, they could override it to `containerID` through a
configuration option `TASK_MANAGER_RESOURCE_ID `. Do I understand it correctly?
If that is the case, user should not set `TASK_MANAGER_RESOURCE_ID` in
active mode (active RMs will override this option anyway). And in standalone
mode, it is user's responsibility to ensure that these ids do not conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
