KarmaGYZ commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r442593692
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -413,9 +413,10 @@ static BackPressureSampleService
createBackPressureSampleService(
* @param configuration The configuration for the TaskManager.
* @param haServices to use for the task manager hostname retrieval
*/
- public static RpcService createRpcService(
- final Configuration configuration,
- final HighAvailabilityServices haServices) throws
Exception {
+ @VisibleForTesting
+ static RpcService createRpcService(
+ final Configuration configuration,
+ final HighAvailabilityServices haServices) throws Exception {
Review comment:
Same as above. I just think it would be good to limit accessibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
