tillrohrmann commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r442692589
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,6 +257,18 @@
text("\"ip\" - uses host's ip address
as binding address"))
.build());
+ /**
+ * The prefix of the TaskManager's ResourceID. If configured, the
ResourceID will be generated with the prefix and a
+ * 6-character random string. Otherwise, a random string will be used.
Only valid in standalone mode.
+ */
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ public static final ConfigOption<String>
TASK_MANAGER_RESOURCE_ID_PREFIX =
+ key("taskmanager.resource-id.prefix")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The prefix of the TaskManager's
ResourceID. If configured, the ResourceID will be generated with the prefix "
+ + "and a 6-character random string. Otherwise,
a random string will be used. Only valid in standalone mode.");
Review comment:
Yes what I mean is to have a single mean how the `ResourceID` is
configured across the different integrations (Yarn, Mesos, K8s). Maybe we
should take a step back and not start with a prefix config option but simply
with `TASK_MANAGER_RESOURCE_ID` which allows to set the `ResourceID`. That way
it would be simple for the RM implementations to configure the `ResourceID`.
Per default it is empty and then we could take the hostname and a random value,
for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
