tillrohrmann commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r442831567
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,6 +257,18 @@
text("\"ip\" - uses host's ip address
as binding address"))
.build());
+ /**
+ * The prefix of the TaskManager's ResourceID. If configured, the
ResourceID will be generated with the prefix and a
+ * 6-character random string. Otherwise, a random string will be used.
Only valid in standalone mode.
+ */
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ public static final ConfigOption<String>
TASK_MANAGER_RESOURCE_ID_PREFIX =
+ key("taskmanager.resource-id.prefix")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The prefix of the TaskManager's
ResourceID. If configured, the ResourceID will be generated with the prefix "
+ + "and a 6-character random string. Otherwise,
a random string will be used. Only valid in standalone mode.");
Review comment:
Why do you want to do it with an environment variable? Can't it be a
configuration value? That way the user could also configure it simply in his
`flink-conf.yaml`.
This would be a configuration value which is specific to the started process
and which should not distributed to other processes, though. I think we already
have similar cases in Flink. See `DeploymentOptionsInternal.CONF_DIR`, for
example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
