tillrohrmann commented on a change in pull request #12054:
URL: https://github.com/apache/flink/pull/12054#discussion_r444113829
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunnerTest.java
##########
@@ -86,6 +88,40 @@ public void
testShouldShutdownIfRegistrationWithJobManagerFails() throws Excepti
assertThat(statusCode,
is(equalTo(TaskManagerRunner.RUNTIME_FAILURE_RETURN_CODE)));
}
+ @Test
+ public void testGenerateTaskManagerResourceIDWithConfig() throws
Exception {
+ final Configuration configuration = createConfiguration();
+ final String resourceID = "test";
+ configuration.set(TaskManagerOptions.TASK_MANAGER_RESOURCE_ID,
resourceID);
+ final String taskManagerResourceID =
TaskManagerRunner.getTaskManagerResourceID(configuration, "", -1);
+
+ assertThat(taskManagerResourceID, equalTo(resourceID));
+ }
+
+ @Test
+ public void testGenerateTaskManagerResourceIDWithRemoteRpcService()
throws Exception {
+ final Configuration configuration = createConfiguration();
+ final String rpcAddress = "flink";
+ final int rpcPort = 9090;
+ final String taskManagerResourceID =
TaskManagerRunner.getTaskManagerResourceID(configuration, rpcAddress, rpcPort);
+
+ assertThat(taskManagerResourceID, notNullValue());
+ assertThat(taskManagerResourceID.substring(0,
taskManagerResourceID.length() - 7),
+ equalTo(rpcAddress + ":" + rpcPort));
+ }
+
+ @Test
+ public void testGenerateTaskManagerResourceIDWithLocalRpcService()
throws Exception {
+ final Configuration configuration = createConfiguration();
+ final String rpcAddress = "";
+ final int rpcPort = -1;
+ final String taskManagerResourceID =
TaskManagerRunner.getTaskManagerResourceID(configuration, rpcAddress, rpcPort);
+
+ assertThat(taskManagerResourceID, notNullValue());
+ assertThat(taskManagerResourceID.substring(0,
taskManagerResourceID.length() - 7),
Review comment:
Same here with the `containsString` matcher
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunnerTest.java
##########
@@ -86,6 +88,40 @@ public void
testShouldShutdownIfRegistrationWithJobManagerFails() throws Excepti
assertThat(statusCode,
is(equalTo(TaskManagerRunner.RUNTIME_FAILURE_RETURN_CODE)));
}
+ @Test
+ public void testGenerateTaskManagerResourceIDWithConfig() throws
Exception {
+ final Configuration configuration = createConfiguration();
+ final String resourceID = "test";
+ configuration.set(TaskManagerOptions.TASK_MANAGER_RESOURCE_ID,
resourceID);
+ final String taskManagerResourceID =
TaskManagerRunner.getTaskManagerResourceID(configuration, "", -1);
+
+ assertThat(taskManagerResourceID, equalTo(resourceID));
+ }
+
+ @Test
+ public void testGenerateTaskManagerResourceIDWithRemoteRpcService()
throws Exception {
+ final Configuration configuration = createConfiguration();
+ final String rpcAddress = "flink";
+ final int rpcPort = 9090;
+ final String taskManagerResourceID =
TaskManagerRunner.getTaskManagerResourceID(configuration, rpcAddress, rpcPort);
+
+ assertThat(taskManagerResourceID, notNullValue());
+ assertThat(taskManagerResourceID.substring(0,
taskManagerResourceID.length() - 7),
Review comment:
maybe use `containsString` matcher
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
