tillrohrmann commented on a change in pull request #12636:
URL: https://github.com/apache/flink/pull/12636#discussion_r442832867
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java
##########
@@ -99,6 +99,13 @@
.withDescription("Enable HTTPs access to the
HistoryServer web frontend. This is applicable only when the" +
" global SSL flag security.ssl.enabled is set
to true.");
+ public static final ConfigOption<Integer> HISTORY_SERVER_RETAINED_JOBS =
+ key("historyserver.archive.retained-jobs")
+ .defaultValue(-1)
+ .withDescription(String.format("The maximum number of
jobs to retain in each archive directory" +
+ " defined by `%s`. If set to `-1`(default) or
negative, there is no limit to the number of archives" +
+ " to keep in the directories and the cache. If
set to `0`, no archives are kept.", HISTORY_SERVER_ARCHIVE_DIRS.key()));
Review comment:
Failing fast if something is wrongly configured is usually a good idea.
One could add an exception message stating that only `-1` or `> 0` values are
valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
