tillrohrmann commented on a change in pull request #12815:
URL: https://github.com/apache/flink/pull/12815#discussion_r449621347
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -753,8 +753,11 @@ public void deploy() throws JobException {
.thenCompose(Function.identity())
.whenCompleteAsync(
(ack, failure) -> {
- // only respond to the failure
case
- if (failure != null) {
+ if (failure == null) {
+ getExecutionGraph()
+
.getExecutionDeploymentListener()
+
.onCompletedDeployment(attemptId,
getAssignedResourceLocation().getResourceID());
Review comment:
Maybe follow a similar pattern as what we do in
`ExecutionVertex.notifyStateTransition`. We could introduce a
`ExecutionVertex.completeDeployment(this)` which does the check whether `this`
is still the `currentExecution`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
