zentol commented on a change in pull request #12815:
URL: https://github.com/apache/flink/pull/12815#discussion_r449634548
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -753,8 +753,11 @@ public void deploy() throws JobException {
.thenCompose(Function.identity())
.whenCompleteAsync(
(ack, failure) -> {
- // only respond to the failure
case
- if (failure != null) {
+ if (failure == null) {
+ getExecutionGraph()
+
.getExecutionDeploymentListener()
Review comment:
Well yes, but that's rather common in the ExecutionGraph?
The alternative I suppose would be to pass the listener through the
constructor, ideally behind some kind of service interface which could evolve
into a set covering all the other stuff we access the vertex/graph for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
