tillrohrmann commented on a change in pull request #12815: URL: https://github.com/apache/flink/pull/12815#discussion_r449641862
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/ExecutionDeploymentReconcilerImpl.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmaster; + +import org.apache.flink.runtime.clusterframework.types.ResourceID; +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; +import org.apache.flink.runtime.taskexecutor.ExecutionDeploymentReport; + +import java.util.HashSet; +import java.util.Set; + +/** + * Default {@link ExecutionDeploymentReconciler} implementation. Detects missing/unknown deployments, and defers + * to a provided {@link ExecutionDeploymentReconciliationHandler} to resolve them. + */ +public class ExecutionDeploymentReconcilerImpl implements ExecutionDeploymentReconciler { + + private final ExecutionDeploymentReconciliationHandler handler; + + public ExecutionDeploymentReconcilerImpl(ExecutionDeploymentReconciliationHandler handler) { + this.handler = handler; + } + + @Override + public void reconcileExecutionDeployments(ResourceID taskExecutorHost, ExecutionDeploymentReport executionDeploymentReport, Set<ExecutionAttemptID> expectedDeployedExecutions) { + final Set<ExecutionAttemptID> executions = new HashSet<>(expectedDeployedExecutions); + + executionDeploymentReport.getExecutions().forEach(executionAttemptID -> { + boolean isTracked = executions.remove(executionAttemptID); + if (!isTracked) { + handler.onUnknownDeployment(executionAttemptID, taskExecutorHost); Review comment: This is an orthogonal discussion. The question here is whether the interface should enforce a single deployment lookup/cancellation call or be flexible enough to support batched calls. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
