StephanEwen commented on a change in pull request #13401: URL: https://github.com/apache/flink/pull/13401#discussion_r491699624
########## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/reader/FileRecordFormatAdapter.java ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.src.reader; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ConfigOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.util.CheckpointablePosition; +import org.apache.flink.connector.file.src.util.IteratorResultIterator; +import org.apache.flink.core.fs.Path; +import org.apache.flink.util.ExceptionUtils; +import org.apache.flink.util.IOUtils; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.util.ArrayList; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * The FormatReaderAdapter turns a {@link FileRecordFormat} into a {@link BulkFormat}. + */ +public final class FileRecordFormatAdapter<T> implements BulkFormat<T> { + + /** + * Config option for the number of records to hand over in each fetch. + * + * <p>The number should be large enough so that the thread-to-thread handover overhead + * is amortized across the records, but small enough so that the these records together do + * not consume too memory to be feasible. + */ + public static final ConfigOption<Integer> RECORDS_PER_FETCH = ConfigOptions Review comment: Good point, I'll move this. Same for the `StreamFormat`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
