StephanEwen commented on pull request #13401:
URL: https://github.com/apache/flink/pull/13401#issuecomment-695828081
> In addition, I am wondering if it would be better to move the classes impl
package to reader instead? And move the current classes/interfaces in reader to
reader.format?
I personally like the current structure better. It has a clear separation
between
- API and specific behavior implementations of that API. These would be
packates that users look at, browse, read the code and JavaDocs.
- `src`, `src.assigners`, `src.compression`, `src.enumerate`,
`src.reader`.
- Internal implementation that users don't need to look at
- `src.impl`
- `And utils are as usual is in the middle, supporting both internal
implementation and API.
- `src.util`
In a follow up commit, I would move the `StreamFormatAdapter` and
`FileRecordFormatAdapter` to `src.impl`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
