StephanEwen commented on a change in pull request #13401: URL: https://github.com/apache/flink/pull/13401#discussion_r491703023
########## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/util/IteratorResultIterator.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.src.util; + +import org.apache.flink.connector.file.src.reader.BulkFormat; + +import javax.annotation.Nullable; + +import java.util.Iterator; + +/** + * A simple {@link BulkFormat.RecordIterator} that returns the elements of an iterator, one after the other. + * + * @param <E> The type of the record returned by the iterator. + */ +public final class IteratorResultIterator<E> implements BulkFormat.RecordIterator<E> { + + private final Iterator<E> records; + + private final MutableRecordAndPosition<E> recordAndPosition; + + public IteratorResultIterator( + final Iterator<E> records, + final long offset, + final long startingSkipCount) { + this.records = records; + this.recordAndPosition = new MutableRecordAndPosition<>(); + this.recordAndPosition.setPosition(offset, startingSkipCount); + } + + // ------------------------------------------------------------------------- + // Result Iterator Methods + // ------------------------------------------------------------------------- + + @Nullable + @Override + public RecordAndPosition<E> next() { + if (records.hasNext()) { + recordAndPosition.setNext(records.next()); + return recordAndPosition; + } else { + return null; + } + } + + @Override + public void close() {} Review comment: Sounds good, will do that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
