aljoscha commented on a change in pull request #13509:
URL: https://github.com/apache/flink/pull/13509#discussion_r497328860
##########
File path:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/sideoutput/SideOutputExample.java
##########
@@ -148,4 +156,29 @@ public void processElement(
}
}
+
+ /**
+ * This {@link WatermarkStrategy} assigns the current system time as
the event-time timestamp.
+ * In a real use case you should use proper timestamps and an
appropriate {@link
+ * WatermarkStrategy}.
+ */
+ private static class IngestionTimeWatermarkStrategy<T> implements
WatermarkStrategy<T> {
Review comment:
I had this in the commit message:
```
I removed calls to set IngestionTime and replaced them by an explicit
IngestionTimeWatermarkStrategy. I duplicated the same
IngestionTimeWatermarkStrategy in all the examples/tests because I
explicitly didn't want to add an IngestionTimeWatermarkStrategy in one
of the core packages so that it is not discoverable because I think we
shouldn't encourage users to use ingestion time.
```
what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
