Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1669#discussion_r53566669
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1487,7 +1487,7 @@ class JobManager(
}
}
- eg.fail(cause)
+ eg.cancel()
--- End diff --
Yes, that would work during shutdown, but there will be a chance that a
`fail` right before `cancelAndClearEverything` will still result in the
restarting behaviour, because multiple calls to `fail` are ignored when the job
status is `FAILING`. `cancel` makes sure that this does not happen, because
cancellation "overwrites" failing behaviour.
If we say that this is OK as a corner case, we can keep the `fail` on
`cancelAndClearEverything` and wrap the Exception to suppress restarts in the
common case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
