Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1669#discussion_r53673891
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1487,7 +1487,7 @@ class JobManager(
}
}
- eg.fail(cause)
+ eg.cancel()
--- End diff --
It is important to make sure that HA recovery continues. The
`cancelAndClearEverything()` is also triggered in `postStop()` if the actor or
actor system crashes (one of JobManager failure scenarios, the process reaper
kills the process then).
We hence need a sort of fail that is not locally retried, but does not lead
to a terminal state where we run the risk that some cleanup code removes the
job from ZooKeeper.
When the job is canceled, don't we run the risk that some code removes the
ZooKeeper entries and prohibits HA recovery?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
