Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1669#discussion_r53678441
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1487,7 +1487,7 @@ class JobManager(
}
}
- eg.fail(cause)
+ eg.cancel()
--- End diff --
The problem is that `postStop()` is not only called when the cluster is
cleanly shut down (and you want job state removed) but in some cases on master
failure, where we need to be sure that state is not removed from ZooKeeper.
The `Integer.MAX_VALUE` issue is less critical...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
