kl0u commented on a change in pull request #13699:
URL: https://github.com/apache/flink/pull/13699#discussion_r509183908
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java
##########
@@ -233,7 +234,7 @@ public void testApplicationFailsAsSoonAsOneJobFails()
throws Throwable {
final CompletableFuture<Void> applicationFuture =
runApplication(dispatcherBuilder, 2);
- assertException(applicationFuture, JobExecutionException.class);
+ assertException(applicationFuture,
ApplicationFailedException.class);
Review comment:
The problem was that we were passing a `Dispatcher` which is difficult
to instantiate and an overkill for such as test. This is the reason why the
`runApplicationAndShutdownClusterAsync()` is annotated as `visibleForTesting`
and is not private, so that all the tests can call this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
