kl0u commented on a change in pull request #13699:
URL: https://github.com/apache/flink/pull/13699#discussion_r509599297
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java
##########
@@ -233,7 +234,7 @@ public void testApplicationFailsAsSoonAsOneJobFails()
throws Throwable {
final CompletableFuture<Void> applicationFuture =
runApplication(dispatcherBuilder, 2);
- assertException(applicationFuture, JobExecutionException.class);
+ assertException(applicationFuture,
ApplicationFailedException.class);
Review comment:
I agree that now we can rethink it, but if I understand the comment
correctly, I tend to disagree that this shows that the class follows a
procedural style. The only reason that this method was exposed was for testing
and it was not accessed by other classes. In that sense, internal state of the
class was not "leaking" as even these methods were sealing internal state from
outside tampering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
