tillrohrmann commented on a change in pull request #13699:
URL: https://github.com/apache/flink/pull/13699#discussion_r509260094
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java
##########
@@ -233,7 +234,7 @@ public void testApplicationFailsAsSoonAsOneJobFails()
throws Throwable {
final CompletableFuture<Void> applicationFuture =
runApplication(dispatcherBuilder, 2);
- assertException(applicationFuture, JobExecutionException.class);
+ assertException(applicationFuture,
ApplicationFailedException.class);
Review comment:
The fact that this worked is actually an indicator that the
`ApplicationDispatcherBootstrap` class is following a quite procedural style.
Maybe with the change that it now takes a `DispatcherGateway` for which we have
easy test implementations one might rethink it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
