Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1699#issuecomment-188406380
+1 changes look good, I had some minor comments but that's just naming
preferences.
Btw, this PR also removes the distinction between `EventTimeSourceFunction`
and regular `SourceFunction`. Where previously only `EventTimeSourceFunction`
could emit elements with timestamps and watermarks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
