JingsongLi commented on a change in pull request #13915:
URL: https://github.com/apache/flink/pull/13915#discussion_r517740881
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveParallelismInference.java
##########
@@ -57,9 +57,9 @@
* Apply limit to calculate the parallelism.
* Here limit is the limit in query <code>SELECT * FROM xxx LIMIT
[limit]</code>.
*/
- int limit(long limit) {
- if (limit > 0) {
- parallelism = Math.min(parallelism, (int) limit / 1000);
+ int limit(Long limit) {
+ if (limit != null) {
+ parallelism = Math.min(parallelism, limit.intValue() /
1000);
Review comment:
Can you change `limit.intValue() / 1000` to `(int) (limit / 1000)`
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSource.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+import org.apache.flink.api.java.typeutils.ResultTypeQueryable;
+import org.apache.flink.connector.file.src.AbstractFileSource;
+import org.apache.flink.connector.file.src.reader.BulkFormat;
+import org.apache.flink.connectors.hive.read.HiveBulkFormatAdapter;
+import org.apache.flink.connectors.hive.read.HiveSourceSplit;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.table.catalog.CatalogTable;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.hadoop.mapred.JobConf;
+
+import javax.annotation.Nullable;
+
+import java.util.List;
+
+import static
org.apache.flink.connector.file.src.FileSource.DEFAULT_SPLIT_ASSIGNER;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * A unified data source that reads a hive table.
+ */
+public class HiveSource extends AbstractFileSource<RowData, HiveSourceSplit>
implements ResultTypeQueryable<RowData> {
+
+ private static final long serialVersionUID = 1L;
+
+ HiveSource(
+ JobConf jobConf,
+ CatalogTable catalogTable,
+ List<HiveTablePartition> partitions,
+ @Nullable Long limit,
+ String hiveVersion,
+ boolean useMapRedReader,
+ boolean isStreamingSource,
+ RowType producedDataType) {
Review comment:
producedRowType
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSource.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+import org.apache.flink.api.java.typeutils.ResultTypeQueryable;
+import org.apache.flink.connector.file.src.AbstractFileSource;
+import org.apache.flink.connector.file.src.reader.BulkFormat;
+import org.apache.flink.connectors.hive.read.HiveBulkFormatAdapter;
+import org.apache.flink.connectors.hive.read.HiveSourceSplit;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.table.catalog.CatalogTable;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.hadoop.mapred.JobConf;
+
+import javax.annotation.Nullable;
+
+import java.util.List;
+
+import static
org.apache.flink.connector.file.src.FileSource.DEFAULT_SPLIT_ASSIGNER;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * A unified data source that reads a hive table.
+ */
+public class HiveSource extends AbstractFileSource<RowData, HiveSourceSplit>
implements ResultTypeQueryable<RowData> {
+
+ private static final long serialVersionUID = 1L;
+
+ HiveSource(
+ JobConf jobConf,
+ CatalogTable catalogTable,
+ List<HiveTablePartition> partitions,
+ @Nullable Long limit,
+ String hiveVersion,
+ boolean useMapRedReader,
+ boolean isStreamingSource,
+ RowType producedDataType) {
+ super(
+ new org.apache.flink.core.fs.Path[1],
+ new
HiveSourceFileEnumerator.Provider(partitions, new JobConfWrapper(jobConf)),
+ DEFAULT_SPLIT_ASSIGNER,
+ createBulkFormat(new JobConf(jobConf),
catalogTable, hiveVersion, producedDataType, useMapRedReader, limit),
Review comment:
I think you should use `LimitableBulkFormat` here.
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveBulkFormatAdapter.java
##########
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.read;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.file.src.reader.BulkFormat;
+import org.apache.flink.connector.file.src.util.ArrayResultIterator;
+import org.apache.flink.connectors.hive.HiveTablePartition;
+import org.apache.flink.connectors.hive.JobConfWrapper;
+import org.apache.flink.formats.parquet.ParquetColumnarRowInputFormat;
+import org.apache.flink.table.catalog.hive.client.HiveShim;
+import org.apache.flink.table.catalog.hive.client.HiveShimLoader;
+import org.apache.flink.table.catalog.hive.util.HiveTypeUtil;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.filesystem.LimitableBulkFormat;
+import org.apache.flink.table.filesystem.PartitionFieldExtractor;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.hadoop.hive.ql.io.IOConstants;
+import org.apache.hadoop.hive.serde2.ColumnProjectionUtils;
+import org.apache.hadoop.mapred.JobConf;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static
org.apache.flink.connector.file.src.util.CheckpointedPosition.NO_OFFSET;
+import static
org.apache.flink.table.data.vector.VectorizedColumnBatch.DEFAULT_SIZE;
+
+/**
+ * A BulkFormat implementation for HiveSource. This implementation delegates
reading to other BulkFormat instances,
+ * because different hive partitions may need different BulkFormat to do the
reading.
+ */
+public class HiveBulkFormatAdapter implements BulkFormat<RowData,
HiveSourceSplit> {
+
+ private static final long serialVersionUID = 1L;
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HiveBulkFormatAdapter.class);
+
+ // schema evolution configs are not available in older versions of
IOConstants, let's define them ourselves
+ private static final String SCHEMA_EVOLUTION_COLUMNS =
"schema.evolution.columns";
+ private static final String SCHEMA_EVOLUTION_COLUMNS_TYPES =
"schema.evolution.columns.types";
+
+ private final JobConfWrapper jobConfWrapper;
+ private final List<String> partitionKeys;
+ private final String[] fieldNames;
+ private final DataType[] fieldTypes;
+ private final String hiveVersion;
+ private final HiveShim hiveShim;
+ private final RowType producedDataType;
+ private final boolean useMapRedReader;
+ // We should limit the input read count of the splits, null represents
no limit.
+ private final Long limit;
+
+ public HiveBulkFormatAdapter(JobConfWrapper jobConfWrapper,
List<String> partitionKeys, String[] fieldNames, DataType[] fieldTypes,
+ String hiveVersion, RowType producedDataType, boolean
useMapRedReader, Long limit) {
+ this.jobConfWrapper = jobConfWrapper;
+ this.partitionKeys = partitionKeys;
+ this.fieldNames = fieldNames;
+ this.fieldTypes = fieldTypes;
+ this.hiveVersion = hiveVersion;
+ this.hiveShim = HiveShimLoader.loadHiveShim(hiveVersion);
+ this.producedDataType = producedDataType;
+ this.useMapRedReader = useMapRedReader;
+ this.limit = limit;
+ }
+
+ @Override
+ public Reader<RowData> createReader(Configuration config,
HiveSourceSplit split)
+ throws IOException {
+ return createBulkFormatForSplit(split).createReader(config,
split);
+ }
+
+ @Override
+ public Reader<RowData> restoreReader(Configuration config,
HiveSourceSplit split) throws IOException {
+ return createBulkFormatForSplit(split).restoreReader(config,
split);
+ }
+
+ @Override
+ public boolean isSplittable() {
+ return true;
+ }
+
+ @Override
+ public TypeInformation<RowData> getProducedType() {
+ return InternalTypeInfo.of(producedDataType);
+ }
+
+ private BulkFormat<RowData, ? super HiveSourceSplit>
createBulkFormatForSplit(HiveSourceSplit split) {
+ if (!useMapRedReader &&
useParquetVectorizedRead(split.getHiveTablePartition())) {
+ PartitionFieldExtractor<HiveSourceSplit> extractor =
(PartitionFieldExtractor<HiveSourceSplit>)
+ (split1, fieldName, fieldType) ->
split1.getHiveTablePartition().getPartitionSpec().get(fieldName);
+ return LimitableBulkFormat.create(
+
ParquetColumnarRowInputFormat.createPartitionedFormat(
+ jobConfWrapper.conf(),
+ producedDataType,
+ partitionKeys,
+ extractor,
+ DEFAULT_SIZE,
+
hiveVersion.startsWith("3"),
+ false),
+ limit);
+ } else {
+ return new HiveMapRedBulkFormat();
+ }
+ }
+
+ private boolean useParquetVectorizedRead(HiveTablePartition partition) {
+ boolean isParquet =
partition.getStorageDescriptor().getSerdeInfo().getSerializationLib()
+ .toLowerCase().contains("parquet");
+ if (!isParquet) {
+ return false;
+ }
+
+ for (RowType.RowField field : producedDataType.getFields()) {
+ if (isVectorizationUnsupported(field.getType())) {
+ LOG.info("Fallback to hadoop mapred reader,
unsupported field type: " + field.getType());
+ return false;
+ }
+ }
+
+ LOG.info("Use flink parquet ColumnarRowData reader.");
+ return true;
+ }
+
+ private static boolean isVectorizationUnsupported(LogicalType t) {
+ switch (t.getTypeRoot()) {
+ case CHAR:
+ case VARCHAR:
+ case BOOLEAN:
+ case BINARY:
+ case VARBINARY:
+ case DECIMAL:
+ case TINYINT:
+ case SMALLINT:
+ case INTEGER:
+ case BIGINT:
+ case FLOAT:
+ case DOUBLE:
+ case DATE:
+ case TIME_WITHOUT_TIME_ZONE:
+ case TIMESTAMP_WITHOUT_TIME_ZONE:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ return false;
+ case TIMESTAMP_WITH_TIME_ZONE:
+ case INTERVAL_YEAR_MONTH:
+ case INTERVAL_DAY_TIME:
+ case ARRAY:
+ case MULTISET:
+ case MAP:
+ case ROW:
+ case DISTINCT_TYPE:
+ case STRUCTURED_TYPE:
+ case NULL:
+ case RAW:
+ case SYMBOL:
+ default:
+ return true;
+ }
+ }
+
+ private class HiveMapRedBulkFormat implements BulkFormat<RowData,
HiveSourceSplit> {
+
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public Reader<RowData> createReader(Configuration config,
HiveSourceSplit split)
+ throws IOException {
+ return new HiveReader(split);
+ }
+
+ @Override
+ public Reader<RowData> restoreReader(Configuration config,
HiveSourceSplit split) throws IOException {
+ assert split.getReaderPosition().isPresent();
+ HiveReader hiveReader = new HiveReader(split);
+
hiveReader.seek(split.getReaderPosition().get().getRecordsAfterOffset());
+ return hiveReader;
+ }
+
+ @Override
+ public boolean isSplittable() {
+ return true;
+ }
+
+ @Override
+ public TypeInformation<RowData> getProducedType() {
+ return InternalTypeInfo.of(producedDataType);
+ }
+ }
+
+ private class HiveReader implements BulkFormat.Reader<RowData> {
+
+ private final HiveMapredSplitReader hiveMapredSplitReader;
+ private final RowDataSerializer serializer;
+ private final ArrayResultIterator<RowData> iterator = new
ArrayResultIterator<>();
+ private final int[] selectedFields;
+ private long numRead = 0;
+
+ private HiveReader(HiveSourceSplit split) throws IOException {
+ selectedFields = computeSelectedFields();
+ JobConf clonedConf = new JobConf(jobConfWrapper.conf());
+ addSchemaToConf(clonedConf);
+ HiveTableInputSplit oldSplit = new
HiveTableInputSplit(-1, split.toMapRedSplit(), clonedConf,
split.getHiveTablePartition());
+ hiveMapredSplitReader = new
HiveMapredSplitReader(clonedConf, partitionKeys, fieldTypes, selectedFields,
oldSplit, hiveShim);
+ serializer = new RowDataSerializer(producedDataType);
+ }
+
+ @Override
+ public RecordIterator<RowData> readBatch() throws IOException {
+ RowData[] records = new RowData[DEFAULT_SIZE];
+ final long skipCount = numRead;
+ int num = 0;
+ while (!hiveMapredSplitReader.reachedEnd() && num <
DEFAULT_SIZE && !reachLimit()) {
+ records[num++] = serializer.copy(nextRecord());
+ }
+ if (num == 0) {
+ return null;
+ }
+ iterator.set(records, num, NO_OFFSET, skipCount);
+ return iterator;
+ }
+
+ @Override
+ public void close() throws IOException {
+ hiveMapredSplitReader.close();
+ }
+
+ private RowData nextRecord() throws IOException {
+ RowData res = hiveMapredSplitReader.nextRecord(null);
+ numRead++;
+ return res;
+ }
+
+ private boolean reachLimit() {
+ return limit != null && numRead >= limit;
Review comment:
Please remove limit things
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveBulkFormatAdapter.java
##########
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.read;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.file.src.reader.BulkFormat;
+import org.apache.flink.connector.file.src.util.ArrayResultIterator;
+import org.apache.flink.connectors.hive.HiveTablePartition;
+import org.apache.flink.connectors.hive.JobConfWrapper;
+import org.apache.flink.formats.parquet.ParquetColumnarRowInputFormat;
+import org.apache.flink.table.catalog.hive.client.HiveShim;
+import org.apache.flink.table.catalog.hive.client.HiveShimLoader;
+import org.apache.flink.table.catalog.hive.util.HiveTypeUtil;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.filesystem.LimitableBulkFormat;
+import org.apache.flink.table.filesystem.PartitionFieldExtractor;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.hadoop.hive.ql.io.IOConstants;
+import org.apache.hadoop.hive.serde2.ColumnProjectionUtils;
+import org.apache.hadoop.mapred.JobConf;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static
org.apache.flink.connector.file.src.util.CheckpointedPosition.NO_OFFSET;
+import static
org.apache.flink.table.data.vector.VectorizedColumnBatch.DEFAULT_SIZE;
+
+/**
+ * A BulkFormat implementation for HiveSource. This implementation delegates
reading to other BulkFormat instances,
+ * because different hive partitions may need different BulkFormat to do the
reading.
+ */
+public class HiveBulkFormatAdapter implements BulkFormat<RowData,
HiveSourceSplit> {
+
+ private static final long serialVersionUID = 1L;
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HiveBulkFormatAdapter.class);
+
+ // schema evolution configs are not available in older versions of
IOConstants, let's define them ourselves
+ private static final String SCHEMA_EVOLUTION_COLUMNS =
"schema.evolution.columns";
+ private static final String SCHEMA_EVOLUTION_COLUMNS_TYPES =
"schema.evolution.columns.types";
+
+ private final JobConfWrapper jobConfWrapper;
+ private final List<String> partitionKeys;
+ private final String[] fieldNames;
+ private final DataType[] fieldTypes;
+ private final String hiveVersion;
+ private final HiveShim hiveShim;
+ private final RowType producedDataType;
+ private final boolean useMapRedReader;
+ // We should limit the input read count of the splits, null represents
no limit.
+ private final Long limit;
Review comment:
Remove limit things in this class
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveBulkFormatAdapter.java
##########
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.read;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connector.file.src.reader.BulkFormat;
+import org.apache.flink.connector.file.src.util.ArrayResultIterator;
+import org.apache.flink.connectors.hive.HiveTablePartition;
+import org.apache.flink.connectors.hive.JobConfWrapper;
+import org.apache.flink.formats.parquet.ParquetColumnarRowInputFormat;
+import org.apache.flink.table.catalog.hive.client.HiveShim;
+import org.apache.flink.table.catalog.hive.client.HiveShimLoader;
+import org.apache.flink.table.catalog.hive.util.HiveTypeUtil;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.filesystem.LimitableBulkFormat;
+import org.apache.flink.table.filesystem.PartitionFieldExtractor;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.typeutils.RowDataSerializer;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.hadoop.hive.ql.io.IOConstants;
+import org.apache.hadoop.hive.serde2.ColumnProjectionUtils;
+import org.apache.hadoop.mapred.JobConf;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static
org.apache.flink.connector.file.src.util.CheckpointedPosition.NO_OFFSET;
+import static
org.apache.flink.table.data.vector.VectorizedColumnBatch.DEFAULT_SIZE;
+
+/**
+ * A BulkFormat implementation for HiveSource. This implementation delegates
reading to other BulkFormat instances,
+ * because different hive partitions may need different BulkFormat to do the
reading.
+ */
+public class HiveBulkFormatAdapter implements BulkFormat<RowData,
HiveSourceSplit> {
+
+ private static final long serialVersionUID = 1L;
+
+ private static final Logger LOG =
LoggerFactory.getLogger(HiveBulkFormatAdapter.class);
+
+ // schema evolution configs are not available in older versions of
IOConstants, let's define them ourselves
+ private static final String SCHEMA_EVOLUTION_COLUMNS =
"schema.evolution.columns";
+ private static final String SCHEMA_EVOLUTION_COLUMNS_TYPES =
"schema.evolution.columns.types";
+
+ private final JobConfWrapper jobConfWrapper;
+ private final List<String> partitionKeys;
+ private final String[] fieldNames;
+ private final DataType[] fieldTypes;
+ private final String hiveVersion;
+ private final HiveShim hiveShim;
+ private final RowType producedDataType;
Review comment:
`producedRowType`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
