JingsongLi commented on a change in pull request #13915:
URL: https://github.com/apache/flink/pull/13915#discussion_r517767226
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -180,15 +182,26 @@ private boolean isStreamingSource() {
}
private DataStream<RowData>
createBatchSource(StreamExecutionEnvironment execEnv,
- TypeInformation<RowData> typeInfo, HiveTableInputFormat
inputFormat) {
- DataStreamSource<RowData> source =
execEnv.createInput(inputFormat, typeInfo);
+ List<HiveTablePartition> allHivePartitions) {
+ HiveSource hiveSource = new HiveSource(
Review comment:
We should use `SourceProvider` instead of `DataStream`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
