becketqin commented on pull request #13920:
URL: https://github.com/apache/flink/pull/13920#issuecomment-724617165


   @StephanEwen Thanks for the detail explanation. I updated the patch to 
address your comments and removed the controversial part. Now the patch only 
contains two commits:
   
   1. Add metric definitions of Source.
       - Expose the Source metrics via `SourceMetricGroup` and 
`SourceReaderContext`.
       - Let `SourceOperator` report the WatermarkLag.
   2. Report numRecordsIn, numRecordsInPerSecond and SourceIdleTime in 
SourceReaderBase.
   
   Would you help take another look? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to