becketqin commented on pull request #13920: URL: https://github.com/apache/flink/pull/13920#issuecomment-725413347
@rmetzger @dianfu I would like to get your opinions about getting this PR into Flink 1.12 release. This PR adds FLIP-33 metrics support to the Source. The reasons I think we should have it in 1.12 are following: 1. It is the last major piece that would make the Source usable in serious case - people won't be able to actually use a connector in production if there is no metric. 2. If the individual connectors implement the metrics by themselves. They may find those metrics clash with the metrics that we add later. 3. FLIP-27 is still a relatively new feature and the patch only touches the Source. So the risk of introducing problem is low. What do you think? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
