rkhachatryan commented on a change in pull request #14052:
URL: https://github.com/apache/flink/pull/14052#discussion_r524391892
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -98,14 +100,11 @@
private final BufferManager bufferManager;
- /**
- * Indicates the last overtaken sequence number by the most recent
{@link CheckpointBarrier}
- * before task thread started checkpoint, or {@code null} if {@link
CheckpointBarrier} hasn't
- * arrived yet.
- */
@GuardedBy("receivedBuffers")
- @Nullable
- private Integer lastOvertakenSequenceNumber = null;
+ private int lastBarrierSequenceNumber = NONE;
Review comment:
The name of this field is also changed, so migrating the type change to
the older commit will only eliminate two changes in the 2nd commit.
Besides that, I'd like to keep the first commit (from the other PR) separate
and untouched to avoid confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
