becketqin opened a new pull request #14104:
URL: https://github.com/apache/flink/pull/14104


   ## What is the purpose of the change
   
   The patch fixes a bug introduced in FLINK-18323 where we delegate 
`SplitEnumrator.start()` to the CoordinatorExecutor without catching exception. 
When the method throws exception, it will result the coordinator thread to 
exit. The fix is catching exception thrown from SplitEnumerator.start() and 
fail the job accordingly, just like the other method delegated to the 
CoordinatorExecutor.
   
   ## Brief change log
   - Catch exception thrown from SplitEnumerator.start().
   
   ## Verifying this change
   A unit test
   `SourceCoordinatorTest.testFailJobWhenExceptionThrownFromStart()` was added 
to verify the fix.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to