[
https://issues.apache.org/jira/browse/FLINK-20509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated FLINK-20509:
-------------------------------
Description: Currently, we use {{verifyPlan}} method to verify the plan
result for both {{RelNode}} plan and {{ExecNode}} plan, because their instances
are the same. But once the implementation of {{RelNode}} and {{ExecNode}} are
separated, we can't get {{ESTIMATED_COST}} and {{CHANGELOG_MODE}} on
{{ExecNode}} plan. So in order to make those methods more clear, the
{{verifyPlan}} method can be separated into two methods, {{verifyRelPlan}} for
verifying the {{RelNode}} plan, and {{verifyExecPlan}} for verifying the
{{ExecNode}} plan. (was: Currently, we use {{verifyPlan}} method to verify
the plan result for both {{RelNode}} plan and {{ExecNode}} plan, because their
instances are the same. But once the implementation of {{RelNode}} and
{{ExecNode}} are separated we can't get {{ESTIMATED_COST}} and
{{CHANGELOG_MODE}} on {{ExecNode}} plan. So in order to make the methods more
clear, the {{verifyPlan}} method can be separated into two methods,
{{verifyRelPlan}} for verifying the {{RelNode}} plan, and {{verifyExecPlan}}
for verifying the {{ExecNode}} plan. )
> Refactor verifyPlan method in TableTestBase
> -------------------------------------------
>
> Key: FLINK-20509
> URL: https://issues.apache.org/jira/browse/FLINK-20509
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: godfrey he
> Priority: Major
>
> Currently, we use {{verifyPlan}} method to verify the plan result for both
> {{RelNode}} plan and {{ExecNode}} plan, because their instances are the same.
> But once the implementation of {{RelNode}} and {{ExecNode}} are separated, we
> can't get {{ESTIMATED_COST}} and {{CHANGELOG_MODE}} on {{ExecNode}} plan. So
> in order to make those methods more clear, the {{verifyPlan}} method can be
> separated into two methods, {{verifyRelPlan}} for verifying the {{RelNode}}
> plan, and {{verifyExecPlan}} for verifying the {{ExecNode}} plan.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
