dawidwys commented on a change in pull request #15146:
URL: https://github.com/apache/flink/pull/15146#discussion_r593192789
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingController.java
##########
@@ -74,82 +90,152 @@ public void barrierAnnouncement(
}
}
+ private void scheduleAnnouncementTimeout(
+ InputChannelInfo channelInfo, CheckpointBarrier announcedBarrier,
int sequenceNumber) {
+ delayedActionRegistration.schedule(
+ () -> {
+ long barrierId = announcedBarrier.getId();
+ if (lastSeenBarrier == barrierId
+ && lastCompletedBarrier < barrierId
+ && activeController == alignedController) {
+ // Let's timeout this barrier
+ unalignedController.barrierAnnouncement(
+ channelInfo, announcedBarrier, sequenceNumber);
Review comment:
After some thinking I am rewriting the code a bit to have just a single
timer registered here that will switch the active controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
