rkhachatryan commented on a change in pull request #15146:
URL: https://github.com/apache/flink/pull/15146#discussion_r593220082
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
##########
@@ -143,7 +143,8 @@ private CheckpointedInputGate createCheckpointedInputGate()
{
inputGates,
getEnvironment().getMetricGroup().getIOMetricGroup(),
getTaskNameWithSubtaskAndId(),
- mainMailboxExecutor);
+ mainMailboxExecutor,
+ timerService);
Review comment:
One more concern: this `timerService` is used for user timers; their
execution and even maintanance (there can be unlimited number of such timers)
may potentially affect (delay) checkpointing.
WDYT? Should we use a dedicated timer/Service?
(ditto other tasks)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
