KurtYoung commented on a change in pull request #15155:
URL: https://github.com/apache/flink/pull/15155#discussion_r613063699
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveDatabaseUtil.java
##########
@@ -32,8 +33,6 @@
import static
org.apache.flink.sql.parser.hive.ddl.SqlAlterHiveDatabase.ALTER_DATABASE_OP;
import static
org.apache.flink.sql.parser.hive.ddl.SqlAlterHiveDatabaseOwner.DATABASE_OWNER_NAME;
import static
org.apache.flink.sql.parser.hive.ddl.SqlAlterHiveDatabaseOwner.DATABASE_OWNER_TYPE;
-import static
org.apache.flink.table.catalog.hive.HiveCatalog.isGenericForCreate;
-import static org.apache.flink.table.catalog.hive.HiveCatalog.isGenericForGet;
/** Util methods for processing databases in HiveCatalog. */
public class HiveDatabaseUtil {
Review comment:
I think this class shouldn't exist, all the methods should be private
method in HiveCatalog
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogTestUtil.java
##########
@@ -209,4 +206,8 @@ private static void checkEquals(
private static void checkEquals(Date v1, Date v2) {
assertEquals(v1.getDaysSinceEpoch(), v2.getDaysSinceEpoch());
}
+
+ private static boolean isGeneric(Map<String, String> properties) {
Review comment:
rename this method to `isHiveTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
