zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627302956
##########
File path: flink-dist/pom.xml
##########
@@ -679,7 +679,7 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration
combine.self="override">
Review comment:
this removal is safe because it is a distinct execution, and hence never
had any effect.
##########
File path: flink-dist/pom.xml
##########
@@ -734,22 +723,11 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration
combine.self="override">
Review comment:
this removal is safe because it is a distinct execution, and hence never
had any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
