zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627304356
##########
File path: flink-kubernetes/pom.xml
##########
@@ -129,7 +129,7 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration
combine.children="append">
Review comment:
afaik this doesn't make sense and just results in any parent
configurations being ignored. Similar to cassandra it is unnecessary because we
aren't doing anything special, and we get rid of an odd special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
