curcur commented on pull request #15897: URL: https://github.com/apache/flink/pull/15897#issuecomment-843760620
@dawidwys Hey Dawid, thanks very much for the PR. I did one pass and I do not see any obvious problem with the change of "blocking after receiving barrier". There are some inline comments above + a few more comments in general (which may not directly related the change made here) 1. I think it worth some explanation (one-sentense doc) for these four states, especially for the flag `alternating`, it would be even better to describe the transition relations between these four (But I do not think this has to be included in this PR though). - AlternatingWaitingForFirstBarrier - AlternatingCollectingBarriers - AlternatingWaitingForFirstBarrierUnaligned - AlternatingCollectingBarriersUnaligned 2. Do we need a test specifically to test the channels are blocked (for this change)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
