curcur commented on a change in pull request #15897:
URL: https://github.com/apache/flink/pull/15897#discussion_r634533055
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingWaitingForFirstBarrierUnaligned.java
##########
@@ -57,35 +57,37 @@ public BarrierHandlerState barrierReceived(
InputChannelInfo channelInfo,
CheckpointBarrier checkpointBarrier)
throws CheckpointException, IOException {
+
// we received an out of order aligned barrier, we should resume
consumption for the
// channel, as it is being blocked by the credit-based network
if (!checkpointBarrier.getCheckpointOptions().isUnalignedCheckpoint())
{
- inputs[channelInfo.getGateIdx()].resumeConsumption(channelInfo);
+ channelState.blockChannel(channelInfo);
Review comment:
I am a bit struggling thinking of cases where out-of-order barriers
come? Since transition happens when
AlternatingWaitingForFirstBarrier#alignmentTimeout, and converting to priority
events happen before transition. On the other hand, all barriers seen has
already have the announcement removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
