curcur commented on a change in pull request #15897:
URL: https://github.com/apache/flink/pull/15897#discussion_r634518013
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingCollectingBarriersUnaligned.java
##########
@@ -74,14 +74,15 @@ public BarrierHandlerState abort(long cancelledId) throws
IOException {
return stopCheckpoint(cancelledId);
}
- private BarrierHandlerState stopCheckpoint(long cancelledId) {
- for (CheckpointableInput input : inputs) {
+ private BarrierHandlerState stopCheckpoint(long cancelledId) throws
IOException {
+ for (CheckpointableInput input : channelState.getInputs()) {
input.checkpointStopped(cancelledId);
}
+ channelState.unblockAllChannels();
if (alternating) {
- return new AlternatingWaitingForFirstBarrier(inputs);
+ return new
AlternatingWaitingForFirstBarrier(channelState.emptyState());
} else {
- return new WaitingForFirstBarrierUnaligned(false, inputs);
+ return new AlternatingWaitingForFirstBarrierUnaligned(false,
channelState);
Review comment:
Should this be `channelState.emptyState()` for unaligned checkpoint as
well?
I guess it means the same thing because
AlternatingWaitingForFirstBarrierUnaligned(false,...) does not have
announcements? But this requires explicit knowledge and implicit assumption of
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
