rkhachatryan commented on pull request #15420: URL: https://github.com/apache/flink/pull/15420#issuecomment-866672744
Thanks for your feedback, I've addressed your comments, PTAL. @Myasuka > I noticed that the confirm and reset logic for InMemoryStateChangelogWriter is empty, are they blocked for the log ownership discussion? No, `InMemoryStateChangelogWriter` just doesn't have to do anything as it keeps everything in memory. So persist() returns handles for the appended changes regardless of any JM decisions. @curcur > you mentioned that "To prevent duplicated effects on recovery record the operation", Can you elaborate what are the duplicated efforts and why in this particular case order matters? It was 02e33f112973f2d1a228ebdd6a7f48fe9b2aa0f4 (`[hotfix][state/changelog] Merge namespaces after logging it`) and I see it was a mistake: I assumed that `changeLogger.namespacesMerged` uses the underlying state, which is not the case. I'll drop this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
